Update JSON tests to use 'std.testing.expectEqual'

[craig-mcd]

Use the more descriptive 'expectEqual' testing function. This is also used in the Zig stdlib tests.

[alichraghi]

that looks complex for new user

[craig-mcd]

It could made more explicit but verbose by splitting out the 'expected' and 'actual' values of the call.

I would still say that is a better testing function to use.

https://ziglang.org/documentation/master/std/#A;std:testing.expectEqual

This function is intended to be used only in tests. When the two values are not equal, prints diagnostics to stderr to show exactly how they are not equal, then returns a test failure error. actual is casted to the type of expected.

[alichraghi]

expectEqual is intended to use for structs and big types. there's no reason to use it over expect when you're comparing integers.

[craig-mcd]

Respectfully, it is used to check simple values.

Running a simple test case of grep -rn "testing.expectEqual(@as" . | wc -l comes back with 620 lines.

https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/Uri.zig#L469
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/array_list.zig#L1111
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/bit_set.zig#L1439
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/math.zig#L897
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/json.zig#L33
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/unicode.zig#L742
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/wasm.zig#L212

It's cool if you want to reject; it was interesting enough giving me a reason do read more of the stdlib code.

[alichraghi]

not rejecting, just wanted to put my two cents. feel free to push merge button if you aren't convinced

[craig-mcd]

Your project mate, just helping where I can 😀. Not fussed either way.