Skip to content
This repository was archived by the owner on Nov 11, 2023. It is now read-only.

Improve overall wording #1

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Improve overall wording #1

merged 2 commits into from
Sep 13, 2021

Conversation

iddev5
Copy link
Contributor

@iddev5 iddev5 commented Sep 13, 2021

This PR makes changes to wording and structure.
No change in code is made. Even the comments in code are not modified so as to be decided separately in future.

@alichraghi
Copy link
Member

thank you!

@alichraghi alichraghi merged commit 7da020f into zigbyexample:main Sep 13, 2021
@iddev5 iddev5 deleted the wording branch September 13, 2021 17:01
@iddev5
Copy link
Contributor Author

iddev5 commented Sep 13, 2021

@alichraghi I just noticed that this PR had a weird side effect that the front page got dropped down to bottom because all other pages having numbers. I didn't not liked the approach the framework is doing for ordering. But maybe we need to change it back to being numbered? (if no other solution is found)

The reason behind removal of indexing from README.md page is that, its the home page and having it numbered might not look good. In another case, it can have the number index 0 to indicate that's its a special page.

@alichraghi
Copy link
Member

I think if we change the name of the main page from h1 to h2 tag, it will be removed from the list, but it will always be displayed as the main page. or, as you said, put 0 behind it

@iddev5
Copy link
Contributor Author

iddev5 commented Sep 13, 2021

The first solution sounds okay to me!

@alichraghi
Copy link
Member

@iddev5 does't work :(
i'll try your solution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants