Update fonts (size, font-stack, fix blur) #1826
Conversation
last-partizan
commented
Mar 4, 2019
last-partizan
commented
- Increased default font-size to 14px, removed custom font-size in some blocks/buttons.
- Use system font stack: https://css-tricks.com/snippets/css/system-font-stack/
- Fix Text in blurred #1819 (blurry fonts in chrome)
- use system fonts - use global font-size vars - increase default font-size to 14px
| @@ -10,12 +10,10 @@ html { | |||
| body { | |||
| color: #000; | |||
| background: none; | |||
| font: 12px/18px 'Open Sans', "Lucida Grande", "Lucida Sans Unicode", Arial, Helvetica, Verdana, sans-serif; | |||
| font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif; | |||
There was a problem hiding this comment.
What about "Open Sans", "Lucida Grande", "Lucida Sans Unicode"?
There was a problem hiding this comment.
I've changed fonts to use "system font stack", and those fonts does not included.
I can add system-ui to font-list, but it will work only on webkit browsers and if you use it as default in your OS.
There was a problem hiding this comment.
@last-partizan, those font families that you took from snippets for Method 1 are used by Github and Wordpress plugin, though they don't include necessary families like Lucida Grande.
Such a decision might be made based on their user's browsers statistics.
The same link (css-tricks article system font stack) says that for Mavericks is used Lucida Grande.
And method n.2 's description provides you with the stack that includes Lucida Grande.
Could you clarify why not include that one or just update this PR with Lucida Grande?
There was a problem hiding this comment.
@last-partizan, I'm sorry, now I realized that -apple-system solves that issue.
There was a problem hiding this comment.
From the Linux perspective, Roboto,Oxygen-Sans,Ubuntu,Cantarell makes no sense if you want to use the system font.
There was a problem hiding this comment.
What we should use for linux then?
Ubuntu - default in ubuntu, and looks good enough.
Cantarell - is default in gnome.
| @@ -10,12 +10,10 @@ html { | |||
| body { | |||
| color: #000; | |||
| background: none; | |||
| font: 12px/18px 'Open Sans', "Lucida Grande", "Lucida Sans Unicode", Arial, Helvetica, Verdana, sans-serif; | |||
| font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif; | |||
There was a problem hiding this comment.
@last-partizan, I'm sorry, now I realized that -apple-system solves that issue.
|
@rockfield Open Sans - it's a main website font. Why u removed them? |
|
@qWici whole point of this change - use system fonts, and not emulate telegram.org. Those fonts is good for telegram.org, but it's better to use system fonts for an app. |
|
Does anything need to be done to get this merged? Just rebased this and there is only one very simple conflict (deleted |
# Conflicts: # yarn.lock
