This repository was archived by the owner on Oct 25, 2023. It is now read-only.
add support for text links with markdown syntax #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow entering of text links (messageEntityTextUrl) using markdown syntax e.g.: [webogram source](https://github.com/zhukov/webogram/)
acran
commented
Oct 14, 2018
| var markdownTestRegExp = /[`_*@]/ | ||
| var markdownRegExp = /(^|\s|\n)(````?)([\s\S]+?)(````?)([\s\n\.,:?!;]|$)|(^|\s)(`|\*\*|__)([^\n]+?)\7([\s\.,:?!;]|$)|@(\d+)\s*\((.+?)\)/m | ||
| var markdownTestRegExp = /[`_*@]|\]\(/ | ||
| var markdownRegExp = new RegExp('(^|\\s|\\n)(````?)([\\s\\S]+?)(````?)([\\s\\n\\.,:?!;]|$)|(^|\\s)(`|\\*\\*|__)([^\\n]+?)\\7([\\s\\.,:?!;]|$)|@(\\d+)\\s*\\((.+?)\\)|\\[([^\\]]+)\\]\\((' + urlRegExp + ')\\)', 'm') |
There was a problem hiding this comment.
Since it may be a bit hard to see what's going on here, let's go through it:
basically this just adds the regex part for matching text links at the very end - pseudo regex: /\[([^\]]+)\]\((urlRegExp)\)/.
To be able to insert and reuse urlRegExp from above the literal regex had to be converted to a string - to be concatenated with urlRegExp - that is then passed to the RegExp constructor, i.e. the delimiting /s were removed/replaced by single quotes and all back slashes had to be escaped (\ -> \\).
This adds two more (relevant) capturing groups:
match[12]: the link textmatch[13]: the url
|
It is a pity that nothing has changed in 2 years, and webogram still does not support markdown links ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support for easily entering text links - i.e. messageEntityTextUrl text entities - using markdown syntax, i.e.
becomes
discussion: should we maybe use a slightly different syntax (e.g.
[[link text]]((url))) and/or add some kind of escaping to allow for sending actual raw markup text? (see bef95d7/#1323)