This repository was archived by the owner on Oct 25, 2023. It is now read-only.
Default font size Fix #274 #1101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Villar <johnvillarzavatti@gmail.com>
…ading needs to meet a better "angular" approach to already-set-values, but i'm no angular guru. Added correct es-es localization to font size selector. Added google translate localization to font size selector to the following locales: de-de, it-it, nl-nl, pt-br, ru-ru. These need a better translation where possible. Fixed hour padding to outbound messages when fonts are larger. Signed-off-by: John Villar <johnvillarzavatti@gmail.com>
stek29
suggested changes
Dec 4, 2017
| @@ -89,6 +89,23 @@ | |||
| <script type="text/javascript" src="js/directives.js"></script> | |||
| <script type="text/javascript" src="js/directives_mobile.js"></script> | |||
| <!-- endbuild --> | |||
|
|
|||
| <script> | |||
There was a problem hiding this comment.
Why are you adding script here? This is bad.
| "country_select_modal_country_zw": "Zimbabwe" | ||
| "country_select_modal_country_zw": "Zimbabwe", | ||
|
|
||
| "list_fonts": {"n": "Normal", "m": "Medium", "l": "Large", "xl": "X-Large"} |
|
@chiguireitor hey, can you fix pull-request? |
|
Hi, i've lost interest in pursuing this PR (FxOS died an untimely death and i replaced the phone with a big assed android which has native telegram with proper font support), if someone is interested on picking up the slack and adding it to mainline, that would be great, it's really not much to do to make it work with current code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font-size on mobile is pretty bad, especially on FxOS 1.3 phones. This PR gives the ability to change between Normal, Medium, Large and X-Large fonts.
Also, changed the whole mobile app font reference to percentage, as font-size was mostly specified as px, and that's a no-no for responsive design.