Skip to content

tweak: let array index less than (2 ** 32 - 1) to fit Standard ECMA #10341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

tweak: let array index less than (2 ** 32 - 1) to fit Standard ECMA #10341

wants to merge 3 commits into from

Conversation

wujieZ
Copy link
Contributor

@wujieZ wujieZ commented Aug 3, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: let array index less than Math.pow(2, 32) - 1 to fit Standard ECMA

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member

posva commented Aug 3, 2019

What is this improving exactly? Is there a case where current version wasn't working?

@wujieZ
Copy link
Contributor Author

wujieZ commented Aug 3, 2019

What is this improving exactly? Is there a case where current version wasn't working?

Thanks, Current version working no problem, but if val more than Math.pow(2, 32) - 1, it always return true, this is not fit Standard ECMA, look this http://www.ecma-international.org/ecma-262/6.0/index.html#sec-array-exotic-objects

@wujieZ wujieZ changed the title tweak: let array index less than Math.pow(2, 32) - 1 to fit Standard ECMA Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants