-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
feat(lint): add type-aware rules #12497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/runtime-core
@vue/reactivity
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →
|
@@ -159,7 +158,7 @@ export const transformFor: NodeTransform = createStructuralDirectiveTransform( | |||
: isTemplate && | |||
node.children.length === 1 && | |||
isSlotOutlet(node.children[0]) | |||
? (node.children[0] as SlotOutletNode) // api-extractor somehow fails to infer this | |||
? node.children[0] // api-extractor somehow fails to infer this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment referring to the now removed assertion?
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Exploration move to tsslint to use type-aware rules in a high-performance manner.
I tested all type-aware rules of
typescript-eslint
and added the ones with no friction from Vue core: