This repository was archived by the owner on May 19, 2021. It is now read-only.
Support relative paths from command line #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for providing product path argument as relative path. This makes it easier to open projects from command line as user doesn't need to provide full path to project directory. It also allows opening the project from current directory by providing . as path argument. Check for relative path was done with just checking if the path isn't a rooted path. If more thorough checks are needed, this StackOverflow thread has discussion on how the current check could be extended. https://stackoverflow.com/questions/5565029/check-if-full-path-given/35046453
|
nice thanks! will be merging these later this week |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for providing product path argument as relative path. This
makes it easier to open projects from command line as user doesn't need
to provide full path to project directory. It also allows opening the
project from current directory by providing . as path argument.
Check for relative path is done with just checking if the path isn't a
rooted path. If more thorough checks are needed, this StackOverflow
thread has discussion on how the current check could be extended.
https://stackoverflow.com/questions/5565029/check-if-full-path-given/35046453