Skip to content

Update AccessKit #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update AccessKit #8152

wants to merge 3 commits into from

Conversation

tronical
Copy link
Member

Fixes #8148

@tronical tronical requested a review from ogoffart April 15, 2025 05:14
@tronical
Copy link
Member Author

@DataTriny
Copy link
Contributor

I'll have a look this evening.

@tronical
Copy link
Member Author

Ah yes, the CI shows what I can see locally now, too: There's an additional condition in access kit now, that makes it panic when the adapter is created after the window was marked as shown. This PR delays creation until we have an active event loop (as required by the new API), but it can't delay the set_visible() call.

There's no shortcut then :-(. For this update to work I'll have to complete the surgery on the entire window creation. That's too risky for me right now so close to the release.

We need the resume protocol to fix this issue, wayland fullscreen support, and for iOS. I probably should've implemented this earlier, but I down-prioritised it :( - apologies.

I'll go ahead and implement this after the release next week, then there's enough time to fix issues that will (most likely) arise from this.

@DataTriny
Copy link
Contributor

The panic is not a new requirement, it is a stricter way of enforcing that the window is indeed shown only after the AccessKit adapter is created. We have found this bug in the wild, but I am surprized that Slint was also affected.

While unfortunate, I understand the risk involved in doing this right before a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants