Added window_handle_06_rc and display_handle_06_rc in WindowAdapter #7910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tronical
reviewed
Mar 21, 2025
| @@ -142,6 +142,7 @@ pub trait WindowAdapter { | |||
|
|
|||
| /// Re-implement this to support exposing raw window handles (version 0.6). | |||
| #[cfg(feature = "raw-window-handle-06")] | |||
| #[deprecated(since = "1.10.0", note = "use `window_handle_06_rc` instead.")] | |||
There was a problem hiding this comment.
I think you mean to deprecate since 1.11 here, as 1.10 has already been released?
|
|
||
| /// Re-implement this to support exposing raw window handles (version 0.6). | ||
| #[cfg(feature = "raw-window-handle-06")] | ||
| fn window_handle_06_rc( |
There was a problem hiding this comment.
For this to compile, I think that you'll need to remove the "old" functions from WindowAdapterInternal and adjust the surrounding code that uses it.
|
Is this PR still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
window_handle_06_rcanddisplay_handle_06_rcinslint::platform::WindowAdapter, existing functions (window_handle_06anddisplay_handle_06) are flawed and can not be used in practical use.I have not removed them but marked them deprecated.