split asm!
parsing and validation
#140490
Draft
+261
−193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
asm!
parsing and validation into two separate steps.The parser constructs a
Vec<RawAsmArg>
, with each element corresponding to an argument to one of theasm!
macros.The validation then checks things like ordering of arguments or that options are not provided twice.
The motivation is #140279, which wants to add
#[cfg(...)]
support to these arguments. This support can now be added in a straightforward way by adding anattributes: ast::AttrVec
field toRawAsmArg
.An extra reason for this split is that
rustfmt
probably wants to format the assembly at some point (currently that appears to be stubbed out, and the formatting is unstable rust-lang/style-team#152).r? @ghost (just want to look at CI for now)
cc @ytmimi we discussed asm formatting a little while ago in rust-lang/rustfmt#6526. Am I correct in assuming that
AsmArgs
does not give enough information for formatting, but thatRawAsmArgs
would (it e.g. does not join information from multiple lines). This must have been an issue before?