Require sanitizers be enabled for asan_odr_windows.rs #140481
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
PG-exploit-mitigations
|
Some changes occurred in tests/ui/sanitizer cc @rcvalle |
wesleywiser
approved these changes
Apr 29, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 30, 2025
Require sanitizers be enabled for asan_odr_windows.rs Issue Details: The `asan_odr_windows.rs` test is failing on AArch64 Windows, as sanitizers aren't supported on that platform. Fix Details: Apply the correct "need sanitizer" requirements to the test.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 30, 2025
…enton Rollup of 9 pull requests Successful merges: - rust-lang#139192 (mention provenance in the pointer::wrapping_offset docs) - rust-lang#140176 (Fix linking statics on Arm64EC) - rust-lang#140404 (rm `TypeVistable` impls for `Canonical`) - rust-lang#140437 (enable msa feature for mips in codegen tests) - rust-lang#140438 (Add `rust.debug-assertions-tools` option) - rust-lang#140446 (chore: fix some tests) - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4) - rust-lang#140476 (chore: delete unused ui/auxiliary crates) - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details:
The
asan_odr_windows.rstest is failing on AArch64 Windows, as sanitizers aren't supported on that platform.Fix Details:
Apply the correct "need sanitizer" requirements to the test.