Skip to content

ast: Remove token visiting from AST visitor #140450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ast: Remove token visiting from AST visitor #140450

wants to merge 1 commit into from
+32 −216

Conversation

petrochenkov
Copy link
Contributor

It's no longer necessary after the removal of nonterminal tokens in #124141.

r? @nnethercote
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
ast: Remove token visiting from AST visitor
4e06fcb 
It's no longer necessary after the removal of nonterminal tokens in rust-lang#124141.
@nnethercote
Copy link
Contributor

nnethercote commented Apr 29, 2025 •
edited
Loading

I previously tried and failed to do this myself. The s/visit_span/mark_span/ trick is what I was missing. Great work, I would r+ this twice if I could :)

@bors r+
@bors
Copy link
Collaborator

bors commented Apr 29, 2025

📌 Commit 4e06fcb has been approved by nnethercote

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
@bors
Copy link
Collaborator

bors commented Apr 30, 2025

☔ The latest upstream changes (presumably #127516) made this pull request unmergeable. Please resolve the merge conflicts.
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
5 participants
@petrochenkov @rust-log-analyzer @nnethercote @bors @rustbot