Skip to content

Fix tests for Rails 8.0.0.rc1 #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix tests for Rails 8.0.0.rc1 #1252

merged 2 commits into from
Oct 21, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Oct 21, 2024

See https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/11437592629/job/31817408337

Fix:

  2) Failure:
ActiveRecord::PredicateBuilderTest#test_registering_new_handlers_for_joins [/usr/local/bundle/bundler/gems/rails-9a35e63d5203/activerecord/test/cases/relation/predicate_builder_test.rb:29]:
Expected /\[regexp_topic\]\.\[title\] ~ 'rails'/i to match "SELECT [topics].* FROM [topics] INNER JOIN [topics] [regexp_topic] ON [regexp_topic].[id] = [topics].[parent_id] AND [regexp_topic].[title] ~ N'rails' WHERE [topics].[type] IN (N'Reply', N'ReplyWithTitleObject', N'SpecialReply', N'WrongReply', N'UniqueReply', N'SillyUniqueReply')".

  3) Error:
EnumTest#test_0100_declare multiple enums at a time coerced:
NoMethodError: undefined method `original_declare multiple enums at a time' for #<EnumTest:0x00007f75716e8488>
    /usr/local/bundle/bundler/gems/rails-9a35e63d5203/activerecord/lib/active_record/test_fixtures.rb:280:in `method_missing'
    test/cases/coerced_tests.rb:2185:in `block in <class:EnumTest>'

  4) Failure:
ActiveRecord::ConnectionAdapters::RegistrationIsolatedTest#test_0001_#resolve raises if the adapter is using the pre 7.2 adapter registration API [/usr/local/bundle/bundler/gems/rails-9a35e63d5203/activerecord/test/cases/connection_adapters/registration_test.rb:76]:
--- expected
+++ actual
@@ -1 +1 @@
-"Database configuration specifies nonexistent 'fake_legacy' adapter. Available adapters are: abstract, fake, mysql2, postgresql, sqlite3, trilogy. Ensure that the adapter is spelled correctly in config/database.yml and that you've added the necessary adapter gem to your Gemfile if it's not in the list of available adapters."
+"Database configuration specifies nonexistent 'fake_legacy' adapter. Available adapters are: abstract, fake, mysql2, postgresql, sqlite3, sqlserver, trilogy. Ensure that the adapter is spelled correctly in config/database.yml and that you've added the necessary adapter gem to your Gemfile if it's not in the list of available adapters."
@aidanharan aidanharan marked this pull request as ready for review October 21, 2024 13:01
@aidanharan aidanharan merged commit f47c372 into main Oct 21, 2024
0 of 4 checks passed
@aidanharan aidanharan deleted the fix-rails-8.0.0.rc1-tests branch October 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant