Skip to content

Add Dark mode #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Add Dark mode #15

merged 3 commits into from
Apr 30, 2021

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Apr 23, 2021

Basically the same as python-telegram-bot/python-telegram-bot#2483, just also made sure to update the GitHub-Buttons to reflect color preferences.

TBH I don't have the first idea about cherrypy & django, so here's what I did:

  1. Pasted the css generated by darkreader.org into website/static/website/dark.css
  2. In website/templates/website/base.html I change the buttons (lines 66/67) and added the dark.css in line 27
  3. ran python manage.py collectstatic

Was that correct?

Here are two screenshots:

Click to expand

image
image

Again, if you don't like it, please just say so :)

@Bibo-Joshi
Copy link
Member Author

Second commit also gives the code windows an updated look:

Click to expand

image
image

Copy link
Member

@starry-shivam starry-shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh i dunno much about CSS and JavaScript so I can't actually review code changes 😅, but i do love dark mode, so great work!

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I barely know anything either, but definitely like the updated code windows and dark mode!

@Bibo-Joshi Bibo-Joshi merged commit 275eb12 into master Apr 30, 2021
@Bibo-Joshi Bibo-Joshi deleted the dark-mode branch April 30, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants