Skip to content

Update example to v13 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Update example to v13 #14

merged 1 commit into from
Oct 14, 2020

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Oct 11, 2020 •
edited
Loading

  1. drop use_context=True, it's no longer needed
  2. annotate the hello function
  3. use f-string b/c v13 dropeed py3.5
  4. use update.effective_user instead of updat.message.from_user

'2. is not strictly necessary, but as type hinting is one of the major additions of v13, I think we should showcase it
3.-4. are even more discussable. format still works, but why stick to old syntax? Also update.message.from_user is closer to pure API, while on the other hand PTBs motto is "more than a wrapper" …
@Poolitzer
Copy link
Member

  1. I love f strings, they are the python spirit imo.
  2. I really prefer using effective over anything else, especially because its our library's spirit. Nothing to criticize there.
  3. Yes. We absolutely should
Poolitzer
Poolitzer approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Bibo-Joshi Bibo-Joshi merged commit a1aa5f3 into master Oct 14, 2020
@Bibo-Joshi Bibo-Joshi deleted the update-v13 branch October 14, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Bibo-Joshi @Poolitzer