Skip to content

Update release process #18342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

Update release process #18342

merged 5 commits into from
Apr 24, 2025
+21 −36

Conversation

saundefined
Copy link
Member

No description provided.

@saundefined saundefined requested a review from derickr April 17, 2025 06:39
@saundefined saundefined self-assigned this Apr 17, 2025
@saundefined saundefined changed the title [ci skip] Update release process with new downloads server Apr 17, 2025
@iluuu1994
Copy link
Member

Windows builds in nightly failed with this message:

Fatal error: Uncaught SDK\Exception: Failed to fetch supported branches in C:\build-cache\sdk\lib\php\libsdk\SDK\Config.php:172

Does this also need to be adjusted here?

https://github.com/php/php-sdk-binary-tools/blob/8ae549bbbe8c05482284e8125edb3023b5520f00/lib/php/libsdk/SDK/Config.php#L10
@saundefined
Copy link
Member Author

@iluuu1994 I guess not.
The URL to download has not changed (e.g. https://downloads.php.net/~windows/releases/php-8.4.6-src.zip).
Just the server to connect to in order to upload the new releases.
@saundefined saundefined added the Category: Documentation This is for documentation inside php-src, not on php.net label Apr 17, 2025
@iluuu1994
Copy link
Member

iluuu1994 commented Apr 17, 2025 •
edited
Loading

In any case, something broke still... I suppose it's possible it was a temporary failure. I'll check again tomorrow. https://downloads.php.net/~windows/php-sdk/deps/ seems fine.
@iluuu1994
Copy link
Member

Oh, actually it's https://downloads.php.net/series/ that fails. This indeed returns a 404. Any idea what changed here?
@derickr
Copy link
Member

derickr commented Apr 17, 2025 •
edited
Loading

The server moved overnight, and it was missing auth tokens. I am working with @shivammathur on this (right now).

Let me see what series/ was about.
@saundefined saundefined changed the title Update release process with new downloads server Apr 17, 2025
@derickr
Copy link
Member

derickr commented Apr 18, 2025

@iluuu1994 @shivammathur says that https://downloads.php.net/series/ never was a working URL. And I think that is right, as we never had any Apache configuration for that URL. I think this PR is good, and we have resolved the availability of the downloads machine. Shivam also says it now works.
derickr
derickr requested changes Apr 18, 2025
View reviewed changes
derickr
derickr reviewed Apr 24, 2025
View reviewed changes
derickr
derickr approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after these two nitty changes.
@saundefined saundefined requested a review from iluuu1994 April 24, 2025 14:34
adoy
adoy approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@adoy adoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thanks
@saundefined saundefined changed the title [WIP] Update release process Apr 24, 2025
@saundefined saundefined merged commit 090b1cf into php:master Apr 24, 2025
1 check passed
@saundefined saundefined deleted the update-rm-process branch April 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation This is for documentation inside php-src, not on php.net
4 participants
@saundefined @iluuu1994 @derickr @adoy