Skip to content

Change to avoid docker pull rate limit issues in GitHub Actions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

MarcHagen
Copy link
Contributor

@MarcHagen MarcHagen commented Nov 19, 2024

We're running into Docker Hub rate limits, causing our GitHub Action runs to fail. This update changes the script to skip update checks if pulling fails, which helps prevent these failures and keeps the build process running smoothly.

Changes:

  • Skip PHP version check if pulling the base image fails.
  • Set PHP memory limit directly in the Dockerfile using echo 'memory_limit=4G' to avoid needing an external file. This removes the dependency on a local php-build.ini file.

Tested these changes in our fork, and builds complete successfully even when rate limits are hit.
We are running this for almost a half-year or so.
This helped make our CI process more reliable.

Thanks for reviewing! 🚀

@g105b
Copy link
Member

g105b commented Nov 21, 2024

This all makes sense, and looks like a nice addition for self-hosted runners, which I don't have that much experience with.

Thank you for your contribution - I hope it helps you and others in the future.

@g105b g105b merged commit 70a5792 into php-actions:master Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants