Skip to content

Update status bar icon color for BigSur #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lweek
Copy link

@Lweek Lweek commented Nov 27, 2020

  • from 10.14 there are dynamic colors available to reflect system colors.

Related to Issue 542:
#542

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2020

CLA assistant check
All committers have signed the CLA.

@Lweek Lweek force-pushed the status-icon-bigsur branch from 78aed34 to d1b6c38 Compare November 27, 2020 16:10
- from 10.14 there are dynamic colors available to reflect system colors.
@Lweek Lweek force-pushed the status-icon-bigsur branch from d1b6c38 to 174fd0f Compare November 27, 2020 16:39
@rickygao
Copy link

Looking forward to the merge of this pr.

@Lweek
Copy link
Author

Lweek commented Nov 28, 2020

It would be cool to try it out on older macOS before merge.

There are two suitable colors for this. LabelColor and ControlTextColor. In past on Catalina I have used .controlTextColor and it worked like charm but on BigSur this color becomes less contrast and it is slightly lighter than I would love. Not horrible but either not perfect. There is no official word about what color is the right one so I experimented and .labelColor fit best for BigSur.

I will try to reach Apple for answer but it will take some time and I think this solution is just fine for now. :)

@rickygao
Copy link

rickygao commented Nov 29, 2020

As is discussed in #504, isTemplate being true may be a better solution?

@Lweek
Copy link
Author

Lweek commented Nov 29, 2020

Well. You draw unread message counter on it and so I think you shall not use isTemplate because it would probably tint the counter as well? Dunno. Somebody should give it a try. :)

@Skyearn
Copy link

Skyearn commented Jun 17, 2021

Well. You draw unread message counter on it and so I think you shall not use isTemplate because it would probably tint the counter as well? Dunno. Somebody should give it a try. :)

How about determine the status bar icon according to the system version? Below 10.14 use .controlTextColor and .labelColorisTemplate being true in 10.15 or higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants