Skip to content

test: prevent extraneous HOSTNAME substitution in test-runner-output #58076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Renegade334
Copy link
Contributor

I have a box named "io". This got a good chuckle out of me.

=== release test-runner-output ===                                            
Path: parallel/test-runner-output
Test failure: 'test-runner/output/junit_reporter.js'
Location: test/parallel/test-runner-output.mjs:330:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
... Skipped lines

+ '<?xml versHOSTNAMEn="1.0" encoding="utf-8"?>\n' +
- '<?xml version="1.0" encoding="utf-8"?>\n' +
    '<testsuites>\n' +
    '\t<testcase name="sync pass todo" time="*" classname="test">\n' +
    '\t\t<skipped type="todo" message="true"/>\n' +
    '\t</testcase>\n' +
    '\t<testcase name="sync pass todo with message" time="*" classname="test">\n' +
...
    '\t</testcase>\n' +
+   '\t<testcase name="async assertHOSTNAMEn fail" time="*" classname="test" failure="Expected values to be strictly equal:true !== false">\n' +
-   '\t<testcase name="async assertion fail" time="*" classname="test" failure="Expected values to be strictly equal:true !== false">\n' +
    '\t\t<failure type="testCodeFailure" message="Expected values to be strictly equal:true !== false">\n' +
    '[Error [ERR_TEST_FAILURE]: Expected values to be strictly equal:\n' +
    '\n' +
    'true !== false\n' +
    '] {\n' +
    "  code: 'ERR_TEST_FAILURE',\n" +
    "  failureType: 'testCodeFailure',\n" +
+   '  cause: AssertHOSTNAMEnError [ERR_ASSERTION]: Expected values to be strictly equal:\n' +
-   '  cause: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:\n' +
    '  \n' +
    '  true !== false\n' +
    '  \n' +
    '      *\n' +
    '      *\n' +
...
    '\t</testcase>\n' +
+   '\t<testcase name="unhandled rejectHOSTNAMEn - passes but warns" time="*" classname="test"/>\n' +
+   '\t<testcase name="async unhandled rejectHOSTNAMEn - passes but warns" time="*" classname="test"/>\n' +
-   '\t<testcase name="unhandled rejection - passes but warns" time="*" classname="test"/>\n' +
-   '\t<testcase name="async unhandled rejection - passes but warns" time="*" classname="test"/>\n' +
    ...,
  operator: 'strictEqual'
}
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 29, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2025
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (53abd1a) to head (ca3e005).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58076      +/-   ##
==========================================
- Coverage   90.20%   90.20%   -0.01%     
==========================================
  Files         630      630              
  Lines      186391   186391              
  Branches    36612    36611       -1     
==========================================
- Hits       168134   168127       -7     
+ Misses      11068    11062       -6     
- Partials     7189     7202      +13     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
7 participants