-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
doc: add default value for the timeout
option of http.Agent
in http.md
#58018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with shortening the commit message (simply omitting in `http.md`
should be sufficient).
The default value seems to actually be // test.js
const http = require('http');
const agent = new http.Agent();
agent.createConnection = function (options) {
console.log(options);
};
const request = http.request({
agent,
host: 'example.com'
});
|
@lpinca Oh, It seems you are right.
But this is just an implicit setting in the code. |
Add default value (0) for the
timeout
option ofhttp.Agent
inhttp.md