Skip to content

Env variables cleanup #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Env variables cleanup #641

merged 2 commits into from
Jan 16, 2024

Conversation

ludomikula
Copy link
Collaborator

Proposed changes

Docker image(s) and helm variables cleanup and rename. To make more sense in the environment variables, we renamed and unified them. As such this is a breaking change for your current docker-compose files!

Here is the table of all old variables names mapped to the new ones:

Old variable name New variable name
REDIS_ENABLED LOWCODER_REDIS_ENABLED
REDIS_URL LOWCODER_REDIS_URL
MONGODB_ENABLED LOWCODER_MONGODB_ENABLED
MONGODB_URL LOWCODER_MONGODB_URL
LOWCODER_MONGODB_EXPOSED
API_SERVICE_ENABLED LOWCODER_API_SERVICE_ENABLED
LOWCODER_API_SERVICE_URL LOWCODER_API_SERVICE_URL
LOWCODER_API_KEY_SECRET LOWCODER_API_KEY_SECRET
LOWCODER_API_RATE_LIMIT
NODE_SERVICE_ENABLED LOWCODER_NODE_SERVICE_ENABLED
LOWCODER_NODE_SERVICE_URL LOWCODER_NODE_SERVICE_URL
FRONTEND_ENABLED LOWCODER_FRONTEND_ENABLED
PUID LOWCODER_PUID
PGID LOWCODER_PGID
DEFAULT_ORGS_PER_USER LOWCODER_MAX_ORGS_PER_USER
DEFAULT_ORG_MEMBER_COUNT LOWCODER_MAX_MEMBERS_PER_ORG
DEFAULT_ORG_GROUP_COUNT LOWCODER_MAX_GROUPS_PER_ORG
DEFAULT_ORG_APP_COUNT LOWCODER_MAX_APPS_PER_ORG
DEFAULT_DEVELOPER_COUNT LOWCODER_MAX_DEVELOPERS
LOWCODER_MAX_REQUEST_SIZE LOWCODER_MAX_REQUEST_SIZE
LOWCODER_MAX_QUERY_TIMEOUT LOWCODER_MAX_QUERY_TIMEOUT
AUTH_EMAIL_ENABLE LOWCODER_EMAIL_AUTH_ENABLED
ENABLE_USER_SIGN_UP LOWCODER_EMAIL_SIGNUP_ENABLED
COMMON_WORKSPACE_MODE LOWCODER_WORKSPACE_MODE
LOWCODER_CREATE_SIGNUP_WORKSPACE LOWCODER_CREATE_WORKSPACE_ON_SIGNUP
ENCRYPTION_PASSWORD LOWCODER_DB_ENCRYPTION_PASSWORD
ENCRYPTION_SALT LOWCODER_DB_ENCRYPTION_SALT
CORS_ALLOWED_DOMAINS LOWCODER_CORS_DOMAINS

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This change breaks your existing docker-compose and helm values.yaml because the environment variables were renamed!

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 27ca2d4
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/65a6b06539285800080ea2b9
😎 Deploy Preview https://deploy-preview-641--lowcoder-test.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludomikula ludomikula requested a review from FalkWolsky January 16, 2024 16:30
@ludomikula ludomikula force-pushed the env-variables-cleanup branch from 2e38f76 to 27ca2d4 Compare January 16, 2024 16:35
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive. What a wonderful contribution to develop step by step more clean structure of the project

@FalkWolsky FalkWolsky merged commit 0d40d43 into dev Jan 16, 2024
@FalkWolsky FalkWolsky deleted the env-variables-cleanup branch January 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants