Skip to content

Migrate Spring Security To Spring 3.x #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

aq-ikhwa-tech
Copy link
Contributor

Proposed changes

  • Add @configuration to the SecurityConfig class as Spring 3 has now removed the @configuration from the @EnableWebFluxSecurity and @EnableReactiveMethodSecurity annotations. Consequently, the configuration was never being applied.

UT:
base-route
user-api

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

- Add @configuration to the security config class wrt migration requirements
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for classy-bombolone-94aec0 canceled.

Name Link
🔨 Latest commit 99876eb
🔍 Latest deploy log https://app.netlify.com/sites/classy-bombolone-94aec0/deploys/64b00d98b48de2000847c382
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@FalkWolsky FalkWolsky merged commit 20ffff8 into main Jul 13, 2023
@FalkWolsky FalkWolsky deleted the fix-multiple-api-server-spring3-issues branch July 13, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants