Skip to content

[FIX] GlobalCSS styles for Modals/Drawers #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2025

Conversation

iamfaran
Copy link
Collaborator

Proposed changes

This fix will allow users to correctly apply styles via the GlobalCSS in Advanced Settings for both Edit/Preview

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • I tested it, and made sure that it doesn't break any existing functionality
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for lowcoder-test failed.

Name Link
🔨 Latest commit 64bcba6
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/67ddbec349e396000851aba5
@raheeliftikhar5 raheeliftikhar5 self-requested a review March 21, 2025 19:48
Copy link
Collaborator

@raheeliftikhar5 raheeliftikhar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this much needed fix related to global css.

@raheeliftikhar5 raheeliftikhar5 merged commit 0e2f420 into lowcoder-org:dev Mar 21, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants