Skip to content

Fix issues on empty variable key & value and removed placeholder variables #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Imiss-U1025
Copy link
Collaborator

@Imiss-U1025 Imiss-U1025 commented Feb 13, 2025

Proposed changes

Fix issues on empty variable key & value and removed placeholder variables

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 5c160a8
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/67ae16a88c2c6800084b2d3e
😎 Deploy Preview https://deploy-preview-1531--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Imiss-U1025 Imiss-U1025 force-pushed the fix/variables_issue_s3 branch from abb850a to 5c160a8 Compare February 13, 2025 15:58
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a million times. That one was important to get solved fast!

@FalkWolsky FalkWolsky merged commit 155bab4 into dev Feb 13, 2025
7 checks passed
@FalkWolsky FalkWolsky deleted the fix/variables_issue_s3 branch February 13, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants