Skip to content

Concurrency user display #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Concurrency user display #1175

merged 10 commits into from
Sep 20, 2024

Conversation

FalkWolsky
Copy link
Contributor

Proposed changes

If a User A edit an Lowcoder app, and another User B also opens the very same app to edit, both would end up in concurrent overwriting of the app Edit states - as Lowcoder as for now only was made for a single-user as Editor.

In our first attempt to support better multi-user (Editor) experience, we introduce with this PR a optimistic locking strategy. We think it is not a true way to go to try to get a real "multi-user interactivity" for app editing to work. It is not really the case that 2 people same time want collaborative want to edit a single app. Still it can happen that by accident and as rather rare case 2 users open an app independently in the same time.

In this PR we introduce a display for "User B" to get a notice, that a "User A" is editing the app.
After a time window of 3 minutes of inactivity of User A - the lock will be removed and User B can go on to edit the app.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 975bcf8
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/66ed72b36d23770008be8d6d
😎 Deploy Preview https://deploy-preview-1175--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FalkWolsky FalkWolsky merged commit 21c7da7 into dev Sep 20, 2024
7 checks passed
@FalkWolsky FalkWolsky deleted the concurrency-user-display branch September 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants