Skip to content

Share underlying DOM global Window with the isolated World #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Share underlying DOM global Window with the isolated World #583

wants to merge 1 commit into from
+83 −69

Conversation

sjorsdonkers
Copy link
Contributor

@sjorsdonkers sjorsdonkers commented Apr 29, 2025 •
edited
Loading

  • Only the main world page holds a HandleScope and an opened Context

  • Isolated Worlds do not hold a HandleScope and the Context is closed by default

  • An isolatedWorld context can only be made when there is a page

  • v8.context no longer live on the scope allowing the isolated world to be constructed after the page creation.

Note, we should probably:

  • rename Executor to World
  • rename Scope to Context
  • store the HandleScope in the SessionState
  • rename the createIsolatedWorld function to something similar to createPage, since the world already exists, adoptPage?, embracePage, assimilatePage? navigatePage, reset/reinitwithPage

[Feel free to merge if approved]
@sjorsdonkers sjorsdonkers requested a review from karlseguin April 29, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sjorsdonkers