-
Notifications
You must be signed in to change notification settings - Fork 226
Type Conversions #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Conversions #57
Conversation
Primera edicion
|
||
There are also cases when we need to explicitly convert a value to the expected type. | ||
Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
También
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you reviewed the wrong commit. That was fixed in the latest one.
I will update this PR with the translation of task and solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?
|
||
There are also cases when we need to explicitly convert a value to the expected type. | ||
Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?
I fixed the typos. I'm curious about the "Tmabién" at line 7. I double checked that is ok in the "Files changed" of this PR. |
- `undefined` is `NaN` as a number, not `0`. | ||
- `"0"` and space-only strings like `" "` are true as a boolean. | ||
- `undefined` es `NaN` como número, no `0`. | ||
- `"0"` y textos que solo contienen espacios como `" "` son `true` como boolean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quedaría mejor cadenas en lugar de textos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En todo el resto del artículo se usa la palabra "texto". Creo que "cadena" o "cadena de caracteres" puede confundir al lector ya que no se ha explicado lo que es.
Mejoras propuestas por @tscandalitta
Mejoras propuestas por @tscandalitta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gracias @tikoflano por estos cambios 🚀
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
No description provided.