Skip to content

Alternation (OR) | #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 3, 2021
Merged

Alternation (OR) | #473

merged 10 commits into from
Feb 3, 2021

Conversation

vplentinax
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team January 17, 2021 18:25
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 17, 2021
Open
joaquinelio
joaquinelio requested changes Jan 17, 2021
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo del escape...
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
vplentinax and others added 5 commits January 19, 2021 17:05
@vplentinax @joaquinelio
Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…
1325296 
…ring/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…
3bb53ad 
…ring/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…
bef3bd5 
…ring/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…
cdbcf15 
…ring/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…
7911a22 
…ring/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
joaquinelio
joaquinelio requested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comillas y espacios,
hay varios pero se me cruzan los ojos tengo que andar + y - zoom, sorry la review deficiente

sugiero una linea que creo que es una mejora conceptual,
no la mando al inglés porque ya estoy molestando demasiado y la ultima Ilya la aprobo de mala gana (y no era buena, en esp quedo mejor)
Claro que si cambia en algo el concepto no lo cambio en ESP si Ilya no lo acepta en ENG, no es el caso.

este es un art corto pero arduo, buen aporte al repo
Ya no tengo objeciones conceptuales, me gustaria que hicieras el merge aceptes o no los nuevos cambios
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio joaquinelio merged commit 7ea15bd into javascript-tutorial:master Feb 3, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested
3 participants
@vplentinax @javascript-translate-bot @joaquinelio