Skip to content

Forms: event and method submit #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 14, 2020
Merged

Forms: event and method submit #454

merged 16 commits into from
Dec 14, 2020

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Dec 9, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team December 9, 2020 21:46
@CLAassistant
Copy link

CLAassistant commented Dec 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
joaquinelio
joaquinelio requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bienvenido

algunos acentos,
las cuestiones de forma podes ignorarme, el articulo es muy claro

tuviste el criterio de traducir value pero no name o type...
aja...
es que siempre ando buscando reviewers, aunque el bot te ignore podes dejar las correcciones y comentarios

otra forma de ayudar,
cada tanto hacemos merge desde ingles,
cuando hay más de un par de lineas descarto los cambios y los paso a issues. "actualizar"
Por un lado es mas facil porque es menos cantidad,
por otro lado mas complejo porque hay que comparar con el repo ingles,
revisar el historial de commits, y corregir los nros de lineas (me ayudo con vscode +gitlens que hace diff con cualquier remoto)
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio
Copy link
Member

Cambio titulo, agrego al issue a mano
confirmarlo al hacer merge
@joaquinelio joaquinelio changed the title Forms event and method submit Dec 10, 2020
@joaquinelio joaquinelio mentioned this pull request Dec 10, 2020
Open
puntope and others added 9 commits December 10, 2020 20:34
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
ed8bf56 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
a3f2a94 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.v…
d5f8910 
…iew/index.html

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
b7350f2 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
9164cba 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/article.md
9e2559a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
a1e0e94 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
8132ed7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
f782995 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope
Copy link
Contributor Author

puntope commented Dec 10, 2020

/done
@puntope puntope closed this Dec 10, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team December 10, 2020 19:36
@puntope puntope reopened this Dec 10, 2020
@puntope
Copy link
Contributor Author

puntope commented Dec 10, 2020

/done
@joaquinelio
Copy link
Member

joaquinelio commented Dec 10, 2020 •
edited
Loading

hola, @puntope
casi ok
eeehhh... quedaron dos sin resolver,
de los que no negocio, "a veces" y un typo

edit
ah, ok: pereza de github "2 hidden...show more"
puntope and others added 2 commits December 10, 2020 22:54
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/article.md
91715b7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/article.md
7cbe071 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope
Copy link
Contributor Author

puntope commented Dec 10, 2020

/done
joaquinelio
joaquinelio approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that s was fast
...

yes!
👍

waiting for the second reviewer now...
vplentinax
vplentinax approved these changes Dec 13, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo bien...
@joaquinelio joaquinelio merged commit 85b14d2 into javascript-tutorial:master Dec 14, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@puntope puntope deleted the Forms-event-and-method-submit branch December 14, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge
5 participants
@puntope @CLAassistant @javascript-translate-bot @joaquinelio @vplentinax