Skip to content

Element size and scrolling #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lgabrielvleon
Copy link
Contributor

Traducción del capítulo Element size and scrolling

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2020

CLA assistant check
All committers have signed the CLA.

@joaquinelio joaquinelio changed the title Lgabrielvleon patch 1 - Element size and scrolling Oct 22, 2020
@joaquinelio
Copy link
Member

joaquinelio commented Oct 22, 2020

Corregido nombre pr / issue17 pa'que Bot lo entienda

MERGE: !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Tiene 4 tasks y mucho formato anidado,
verificar online como quedan, imposible probarlo debtro del hub

Listo, cuando se me pase la pereza lo reviso.
Hasta mañana zzzz

@joaquinelio joaquinelio self-requested a review October 22, 2020 12:31
@vplentinax vplentinax requested review from vplentinax and removed request for a team October 25, 2020 17:01
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varias cosas...
suelo re-revisar mi revision pero me estoy durmiendo

creo que edite el archivo para cambiar numeracion, si no fue en otro

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

lgabrielvleon and others added 2 commits October 25, 2020 19:13
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Copy link
Contributor Author

@lgabrielvleon lgabrielvleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/done

lgabrielvleon and others added 2 commits October 25, 2020 19:24
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que hoy tengo los ojos más limpios, encontré varios acentos faltantes...

Y vi que hay correcciones de tilde no aplicadas. Puedo dejarme convencer en css, pero con los acentos estoy bastante convencido...

Lo importante es que el texto se lee bien, lo prefiero online-

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Copy link
Member

@vplentinax
podes hacer lo mismo aqui?
este pr es completo, fue revisado, lo corrigio,
más revision y asi quedó

Tuvo ya mucho trabajo hecho, si te parece revisa y revisa mi revision,
es una buena adicion al repo

vplentinax and others added 16 commits December 17, 2020 12:56
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…tion.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien. Avancemos.

@joaquinelio joaquinelio merged commit bf393d0 into javascript-tutorial:master Dec 17, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants