-
Notifications
You must be signed in to change notification settings - Fork 226
Browser default actions #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser default actions #378
Conversation
a5d87fc
to
243a87c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creo que no hay errores y todas son sugerencias de estilo, aplicala s o cambialas si queres
2-ui/2-events/04-default-browser-action/1-why-return-false-fails/solution.md
Outdated
Show resolved
Hide resolved
2-ui/2-events/04-default-browser-action/2-catch-link-navigation/solution.md
Outdated
Show resolved
Hide resolved
2-ui/2-events/04-default-browser-action/3-image-gallery/source.view/index.html
Outdated
Show resolved
Hide resolved
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…ls/solution.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…n/solution.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>
….view/index.html Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…4/es.javascript.info into Browser-default-actions
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿me disculpas que haya agregado mas cosas? de estilo tambien
salvo un acento faltante que note haciendo zoom
2-ui/2-events/04-default-browser-action/2-catch-link-navigation/task.md
Outdated
Show resolved
Hide resolved
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…n/task.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bien!
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
please review my PR