Cross-window communication #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquinelio
requested changes
Sep 1, 2020
There was a problem hiding this comment.
Bot no puso #pr al issue, ojo reviewerrs
me acabo de dar cuenta de q Ilya peca de "en otras palabras"
pero no voy a leer el coso este de nuevo,
aviso por si alguien tiene ganas de mechar alternativas, "e decir"
por ahi ni vale la pena
el coso ete esta bueno, cambio menores solo ssugeridos
no pierdan tiempo que vaya a merge
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
|
/done |
joaquinelio
approved these changes
Sep 1, 2020
EzequielCaste
requested changes
Sep 1, 2020
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
|
/done |
EzequielCaste
approved these changes
Sep 1, 2020
|
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my PR