Skip to content

Walking the DOM #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 29, 2020
Merged

Walking the DOM #318

merged 24 commits into from
Jul 29, 2020

Conversation

Leired7
Copy link
Contributor

@Leired7 Leired7 commented Jul 24, 2020

Artículo, task y soluciones traducido
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@joaquinelio joaquinelio self-requested a review July 24, 2020 23:23
joaquinelio
joaquinelio requested changes Jul 24, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buena adición al repo,

algún typo,
algún cambio de construcción opinable (que podes ignorar y marcar resuelto)

Esstuve tentado a pedir algo más neutral de "una pega"
pero, argentino, la entendí, es perfecta.

Vamos segundo reviewer, ven a reviegüesear...

EDIT: nota, Don Segundo Reviewer: el bot no lo reconoció, lo agrego a mano. Arreglé el nombre supongo que con DOM mayúsculas lo verá cuando merge. Verificar...
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio joaquinelio changed the title Walking the dom Jul 25, 2020
@iliakan iliakan mentioned this pull request Jul 25, 2020
Open
maksumi
maksumi reviewed Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@maksumi maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy buena traducción. Solo arreglar unos tipos y considerar algunas sugerencias para mantener un lenguaje simple en la traducción
Leired7 and others added 13 commits July 27, 2020 07:46
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/1-dom-children/solution.md
67bd1d3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/article.md
6cc23a4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/article.md
6a28723 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/article.md
7fac6f6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/1-dom-children/task.md
bbbd56e 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/3-navigation-links-which-nul…
38348d2 
…l/task.md

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
c15ada0 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
2e3d02f 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
fbaaed1 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
1501fe9 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
04ec290 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
f416a1c 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
0796f8b 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 Leired7 closed this Jul 27, 2020
@Leired7 Leired7 reopened this Jul 27, 2020
@Leired7
Update 2-ui/1-document/03-dom-navigation/article.md
b9880b2 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 Leired7 closed this Jul 27, 2020
@Leired7 Leired7 reopened this Jul 27, 2020
@Leired7
Update 2-ui/1-document/03-dom-navigation/1-dom-children/task.md
59135ff 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 Leired7 requested a review from joaquinelio July 27, 2020 06:12
@Leired7
Copy link
Contributor Author

Leired7 commented Jul 27, 2020

/done
@Leired7 Leired7 closed this Jul 27, 2020
@joaquinelio
Copy link
Member

@Leired7 ... ¿closed?
Supongo que ya estaba listo para última mirada e integrarlo,
¿puedo suponer que fue un error de "dóndehagoclicahora"? je je tuve muchos de esos cuando empecé con la traducción...
@Leired7
Copy link
Contributor Author

Leired7 commented Jul 28, 2020

Síiii @joaquinelio!!!! exactamente paso eso! ¿Dónde "tengoqueclickarahora"?
@joaquinelio
Copy link
Member

No problem...
El autor puede cerrarlo para modificar sin que nadie lo moleste y reabrirlo o dejarlo cerrado y hacer uno nuevo, no pasa nada.
Acá abajo, "Reopen and comment"...
Pero como dijiste que fuer por error, me tenté y abro y reviso...
@joaquinelio joaquinelio reopened this Jul 28, 2020
joaquinelio and others added 2 commits July 28, 2020 12:12
@joaquinelio
Update 2-ui/1-document/03-dom-navigation/article.md
02b92bd 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Apply suggestions from code review
eb16ae9 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
joaquinelio
joaquinelio approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No es perfecto, (sutilezas intraducibles)
pero menos será si hacemos de la redacción una asamblea.
Apliqué un par de sug de maksumi, dejé un par afuera, y otra que hice y no supe mejorar.
Funciona como está.
@Leired7
Copy link
Contributor Author

Leired7 commented Jul 28, 2020

Muchas gracias por la ayuda ☺️ @joaquinelio
@maksumi
Copy link
Collaborator

maksumi commented Jul 28, 2020

Merge it! Ya llegará el momento de detallar las sutilezas
@vplentinax vplentinax merged commit 9002711 into javascript-tutorial:master Jul 29, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@Leired7
Copy link
Contributor Author

Leired7 commented Jul 29, 2020

¡Qué alegría! jejej Gracias!!!

A por el siguiente....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge
7 participants
@Leired7 @CLAassistant @javascript-translate-bot @joaquinelio @maksumi @dbritto-dev @vplentinax