Skip to content

Reference Type #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 21, 2020
Merged

Reference Type #304

merged 20 commits into from
Jul 21, 2020

Conversation

maksumi
Copy link
Collaborator

@maksumi maksumi commented Jul 15, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 15, 2020 19:02
@iliakan iliakan mentioned this pull request Jul 15, 2020
Open
joaquinelio
joaquinelio requested changes Jul 16, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nada que decir, si no lo entendí.

Corregi los typos al menos.

Andamos escasos de reviewers qye sepan js en profundidad como esto.
Iguual Creo que el capitulo no esta muy deporado en el original...
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Maksumi Murakami and others added 12 commits July 15, 2020 21:52
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
827a48a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
f459aff 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
90dcbca 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/3-why-this/solution.md
16fc3ae 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update solution.md
88604af
Update solution.md
60f27d1
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
18cfb4c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
a08a5d7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
9fdf550 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
a57880d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
06b8de6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
6b51296 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi
Copy link
Collaborator Author

maksumi commented Jul 16, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from a team July 16, 2020 03:19
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
dc5f7b4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi
Copy link
Collaborator Author

maksumi commented Jul 16, 2020

/done
@maksumi maksumi requested review from joaquinelio and removed request for a team July 17, 2020 07:02
Maksumi Murakami and others added 2 commits July 18, 2020 11:42
Actualizado
53802ac
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
302b965 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi
Copy link
Collaborator Author

maksumi commented Jul 18, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from a team July 18, 2020 16:43
joaquinelio
joaquinelio approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que está perfecto en concepto.

typos.
@vplentinax
Copy link
Contributor

Corregir typos y aceptamos!
Maksumi Murakami and others added 3 commits July 20, 2020 16:20
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
892c569 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
1edd325 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
f7e3cc4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi
Copy link
Collaborator Author

maksumi commented Jul 20, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from a team July 20, 2020 21:22
vplentinax
vplentinax approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nos fuimos!
@joaquinelio joaquinelio merged commit 17864bb into javascript-tutorial:master Jul 21, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge
4 participants
@maksumi @javascript-translate-bot @vplentinax @joaquinelio