Skip to content

Promise #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 9, 2020
Merged

Promise #288

merged 7 commits into from
Jul 9, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jun 29, 2020

se ha cerrado PR #188, este es su reemplazo. Razón: el branch anterior se eliminó
@javascript-translate-bot javascript-translate-bot requested a review from a team June 29, 2020 02:48
@javascript-translate-bot
Copy link

Error: the article already has PR number in the Progress Issue #17, it's 188 ⁉️
@iliakan iliakan mentioned this pull request Jun 30, 2020
Open
@joaquinelio joaquinelio self-requested a review June 30, 2020 14:28
joaquinelio
joaquinelio requested changes Jun 30, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

salvo "prometedor" por objeto "promesa"
cambios menores y lo doy por bueno.
podrias buscar y poner apertura ¡
a los !
pero si no tenes ganas me olvido y miro para otro lado, no me importa
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@cortizg
Copy link
Contributor Author

cortizg commented Jun 30, 2020

salvo "prometedor" por objeto "promesa"
cambios menores y lo doy por bueno.
podrias buscar y poner apertura ¡
a los !
pero si no tenes ganas me olvido y miro para otro lado, no me importa

Ok.... En casa lo reviso!
@cortizg @joaquinelio
Update 1-js/11-async/02-promise-basics/02-delay-promise/task.md
4d320d0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
cortizg
cortizg commented Jul 1, 2020
View reviewed changes
Copy link
Contributor Author

@cortizg cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acento
@cortizg cortizg requested a review from joaquinelio July 1, 2020 02:15
@cortizg
Copy link
Contributor Author

cortizg commented Jul 1, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from a team July 1, 2020 03:06
joaquinelio
joaquinelio approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Una belleza, quién no va a entender las Promise ahora.
Me enamoré del sitio gracias a este capítulo.
@vplentinax vplentinax self-requested a review July 9, 2020 03:22
vplentinax
vplentinax approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!
@joaquinelio joaquinelio merged commit 1787914 into javascript-tutorial:master Jul 9, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge
4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax