Skip to content

Function expressions #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2020
Merged

Function expressions #272

merged 2 commits into from
Jul 5, 2020

Conversation

EzequielCaste
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team June 22, 2020 19:30
@iliakan iliakan mentioned this pull request Jun 22, 2020
Open
cortizg
cortizg suggested changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@cortizg cortizg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy buena traducción, 1 typo: excelente, full review
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@EzequielCaste @cortizg
Update 1-js/02-first-steps/16-function-expressions/article.md
ce72f3b 
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste
Copy link
Contributor Author

/done
@EzequielCaste
Copy link
Contributor Author

@cortizg lo tienes que aprobar después que hice los cambios.
@cortizg
Copy link
Contributor

cortizg commented Jun 28, 2020

@cortizg lo tienes que aprobar después que hice los cambios.

copiado, jejeje estoy rucky aùn!
@cortizg
Copy link
Contributor

cortizg commented Jun 28, 2020

/done
@EzequielCaste
Copy link
Contributor Author

@cortizg Falta la aprobación.
el "done" lo hace el autor del PR para decir que ya realizó los cambios que le fueron solicitados.
vplentinax
vplentinax approved these changes Jul 5, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!
@EzequielCaste EzequielCaste merged commit 407cffc into javascript-tutorial:master Jul 5, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs +1
4 participants
@EzequielCaste @javascript-translate-bot @cortizg @vplentinax