Skip to content

Numbers #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2020
Merged

Numbers #200

merged 4 commits into from
Jun 6, 2020

Conversation

joaquinelio
Copy link
Member

1.5.2 number completito y probado con server local

NOTAS

diff - Me basé en EN.javascript.info
que es más nuevo, tiene algunas correcciones,
e incluye breve descripción de bigInt (hay un link al capítulo bigInt que no existe -easy fix, boss-)

Volé (parte de) un párrafo que tiene sentido en inglés pero no en castellano,
referida a cómo abrevian en palabras los números "somos perezosos", en español no usamos esas abreviaturas y en ESTE particular caso no tiene sentido explicarlas y aclarar que nosotros no lo hacemos.

Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me pareció bien.
sugerí algunos cambios.
🚀 🍕

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio and others added 2 commits June 2, 2020 00:25
/done

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
/done

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio joaquinelio changed the title numbers Jun 3, 2020
@joaquinelio joaquinelio requested a review from EzequielCaste June 4, 2020 06:36
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vplentinax vplentinax merged commit e94892d into javascript-tutorial:master Jun 6, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio joaquinelio deleted the numbers branch July 15, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants