Skip to content

fix(tokens): fix usage on components and review scss architecture #30368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Apr 23, 2025
Merged

fix(tokens): fix usage on components and review scss architecture #30368

merged 49 commits into from
Apr 23, 2025

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Apr 21, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

Added improvements on scss architecture, as identified on past assessment, on multiple components.

Some of these changes resulted in snapshots differences, all reviewed and expected:

  • Button spinner - pics with no visual differences/false-positive.
  • Item slider - difference due to updated typography token.
  • Item - difference as is now using correct disabled styles tokens.
  • searchbar: 1px difference on horizontal margin - expected - to start using a more rounded value from a token.
  • Tab/tab-button - difference as is now using correct typography token.
  • Spinner/loading - this looks like a false positive, saw no visible differences.
  • Textarea - this looks like a false positive, saw no visible differences.
  • Typography - this looks like a false positive, saw no visible differences.

Does this introduce a breaking change?

  • Yes
  • No
@vercel Vercel
Copy link

vercel bot commented Apr 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 3:45pm
@github-actions github-actions bot added the package: core @ionic/core package label Apr 21, 2025
@BenOsodrac BenOsodrac added the type: bug a confirmed bug report label Apr 21, 2025
@BenOsodrac BenOsodrac changed the title fix(tokens): fix tokens usage on components Apr 22, 2025
@BenOsodrac BenOsodrac marked this pull request as ready for review April 22, 2025 15:53
@BenOsodrac BenOsodrac requested a review from a team as a code owner April 22, 2025 15:53
@BenOsodrac BenOsodrac requested review from ShaneK and brandyscarney and removed request for ShaneK April 22, 2025 15:53
brandyscarney
brandyscarney requested changes Apr 22, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few questions on some implementation details. 🙂
@BenOsodrac BenOsodrac merged commit 02c1388 into next Apr 23, 2025
48 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11814-components branch April 23, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
3 participants
@BenOsodrac @brandyscarney @Ionitron