Skip to content

Add popup if upstream branch is not set when pushing #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WizardOhio24
Copy link
Contributor

Closes #492

Adds a popup on push with the list of possible remote branches if no remote branch is set. At the bottom of the list is the name of the branch which may exist in remote repo but which can be pushed (-u) and added if it is not there. This allows the user to select one of the remote branches which are connected to their repo or push their own branch name.
Screenshot_20210206_215743

Would it be better to not list all the remote branches? i.e only list origin/<branch_name>, <some_remote>/<branch_name>, or do it the way it is right now, with all the branches?
Perhaps a drop down list, where origin and <some_remote> could be selected to push to them with the branch name, or they could be dropped down to selected a specific branch.

And should the user be able to set the branch upstream by pressing, e.g U on in the status tab to bring up the upstreams? I think a dedicated branch tab for dealing with local/remote branches would be better, but would be happy to add a Set upstream [U] button.

Any suggestions on how to handle this would be appreciated.

@WizardOhio24 WizardOhio24 changed the title Add popup if upstream branch not set when pushing Feb 6, 2021
@extrawurst
Copy link
Collaborator

please refer to #491 for the details, the point is to allow selecting the remote not the branchname - a list of all available remotes is sufficient to fix #491

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dormant Marked by stale bot on close
2 participants