The progress arg to push, pull, fetch and clone is now a python calla… #450
Conversation
…ble. This simplifies the API and removes the parser, RemoteProgres, from the API as RemoteProgress is an internal detail of the implementation. progress is accepted as: * None - drop progress messages * callable (function etc) - call the function with the same args as update * object - assume its RemoteProgress derived as use as before RemoteProgress takes an optional progress_function argument. It will call the progress function if not None otherwise call self.update as it used to.
|
I'm new to github workflow. The PR is not no master correctly. Not sure of how to redo this. |
|
Thanks for your contribution ! I generally like the way it is implemented, but will make a few line-comments in a moment. |
|
|
||
| messages is '' if there is no additon message. | ||
|
|
||
| Deprecated: Pass in a class derived from git.RemoteProgres that |
There was a problem hiding this comment.
I see no reason to deprecate this - it should be fine to just remove Deprecated: here.
|
Oh, and before I forget: Could you add the upcoming API improvement in the |
Minor adjustments to PR to match current code style. Related to #450
That way, the base type doesn't need any adjustment. Related to #450
|
Just to save us some time, I merged and made some modifications myself. |
…ble.
This simplifies the API and removes the parser, RemoteProgres,
from the API as RemoteProgress is an internal detail of the implementation.
progress is accepted as:
RemoteProgress takes an optional progress_function argument.
It will call the progress function if not None otherwise call self.update
as it used to.