Closing file handles/streams #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for this contribution - plenty of issues showed up in the past because of this ! |
|
There are sill more somewhere but we haven't found them yet. |
|
Gitdb is the other location which deals with files, sometimes indirectly through the use of smmap. I would suspect smmap, as each mmap opened on a file will effectively duplicate the file-handle. If the original is not closed, there would be a leak. It's just a guess of mine, which would need to be verified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our debugging of GitPython during usage a while ago showed we were leaking some file handles. We think this resolves some of the issues.