Proposition to make comparisons between GitPython objects and non-GitPython objects possible. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Mike, I specifically favored performance when implementing this, hence there are no extra compatibility checks, but the question is where this tad of performance will make an actual difference. People who want performance would save the method call and just do the A little bit of convenience is probably not a bad idea in this case, and I merged your request. Thanks, |
Byron
added a commit
that referenced
this pull request
May 19, 2011
improved comparison between Object instances to check for compatibility of the other side first. Previously, and exception would be thrown. This adds convenience in an area which probably is not performance critical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to compare for instance None with a Commit, I'm suggesting that we check that 'other' has the attribute binsha before comparing. (also, see issue #15).
Thanks.