Skip to content

Failing (or warning?) with Python 3.12 alpha 7 #1571

Closed
@henryiii

Description

@henryiii

I think things like this

return shutil.rmtree(path, False, onerror)
is causing a problem, due to https://docs.python.org/3.12/whatsnew/3.12.html#shutil (see python/cpython#102829 ). While I do have warnings as errors on in my test suite, this is not reporting a warning like wheel does, it's an error when calling repo.index.commit("first commit"):

/opt/hostedtoolcache/Python/3.12.0-alpha.7/x64/lib/python3.12/site-packages/git/refs/symbolic.py:172: in _get_ref_info_helper
    repodir = _git_dir(repo, ref_path)
        cls        = <class 'git.refs.head.Head'>
        ref_path   = 'refs/heads/main'
        repo       = <git.repo.base.Repo '/tmp/pytest-of-runner/pytest-0/test_plugin_metadata0/pkg/.git'>
        tokens     = None
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

repo = <git.repo.base.Repo '/tmp/pytest-of-runner/pytest-0/test_plugin_metadata0/pkg/.git'>
path = 'refs/heads/main'

    def _git_dir(repo: "Repo", path: Union[PathLike, None]) -> PathLike:
        """Find the git dir that's appropriate for the path"""
        name = f"{path}"
        if name in ["HEAD", "ORIG_HEAD", "FETCH_HEAD", "index", "logs"]:
            return repo.git_dir
>       return repo.common_dir
E       SystemError: <function Repo.common_dir at 0x7ffba93f3060> returned a result with an exception set

name       = 'refs/heads/main'
path       = 'refs/heads/main'
repo       = <git.repo.base.Repo '/tmp/pytest-of-runner/pytest-0/test_plugin_metadata0/pkg/.git'>

/opt/hostedtoolcache/Python/3.12.0-alpha.7/x64/lib/python3.12/site-packages/git/refs/symbolic.py:55: SystemError

GHA's 3.12-dev just updated to alpha 7, which is why I am now seeing this error.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions