Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gitpython-developers/GitPython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 993f045
Choose a base ref
...
head repository: gitpython-developers/GitPython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2a2ae77
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 1, 2023

  1. update instructions for how to create a release

    @Byron
    Byron committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f882cd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. util: close lockfile after opening successfully 

    Otherwise, this will leak file handles and can be a problem in Windows.
Also, `closefd=true` is the default here, so need to pass it explicitly.

Regression from #1619.

I noticed after [our tests started raising `ResourceWarning`][1].

```python
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/git/util.py", line 938, in _obtain_lock_or_raise
    open(lock_file, mode='w', closefd=True)
ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/pytest-of-runner/pytest-0/popen-gw0/external0/project.git/.git/config.lock' mode='w' encoding='UTF-8'>
```

[1]: https://github.com/iterative/dvc/actions/runs/6055520480/job/16434544764#step:6:869
    @skshetry
    skshetry committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    3e829eb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1639 from skshetry/close-lockfile 

    util: close lockfile after opening successfully
    @Byron
    Byron authored Sep 2, 2023
    Configuration menu
    Copy the full SHA
    4714740 View commit details
    Browse the repository at this point in the history

  3. prepare patch release

    @Byron
    Byron committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    2a2ae77 View commit details
    Browse the repository at this point in the history
Loading