Skip to content

feat: support freebsd #9041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Martinfx
Copy link

No description provided.

Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 1b5b305

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@absidue
Copy link

absidue commented Apr 21, 2025

As electron-builder defaults to downloading the official Electron builds and they don't have FreeBSD builds, it should probably be documented that these FreeBSD options can only be used in combination with a custom Electron build e.g. the electronDist or electronDownload options.

@mmaietta
Copy link
Collaborator

it should probably be documented that these FreeBSD options can only be used in combination with a custom Electron build e.g. the electronDist or electronDownload options.

Love this feedback. Yes, completely agree with this.

Also, we'll need a unit test for this since it's proposing an entirely new platform target. Is there an artifact (anywhere) that we can use electronDownload for pulling the artifact for a unit test?

Additionally, is there any special config required for freebsd? Not sure what Target is supposed to be getting built with here, right now it only looks like configuration params are accepted.

@mmaietta mmaietta changed the title electron-builder: support freebsd Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants