-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(snap): migrate snap generation from app-builder-bin to JS #8892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: aef891c The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # test/src/linux/snapHeavyTest.ts
LGTM |
The snap compiled with this version fails to install, with the following error:
Using the same configuration with 26.0.10 works without any issues.
|
electron-builder.yaml
|
|
||
let out: string | ||
try { | ||
out = await exec("snapcraft", ["--version"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After installing snapcraft, if /snap/bin is not in the PATH, it will keep reporting errors. Then, when you try to install it again, it says it's already installed.
Can this error message be more specific, or suggest using /snap/bin/snapcraft? This would be more user-friendly for first-time snap users. I am a first-time user myself, so if there were more specific prompts, I would know to add /snap/bin to the PATH. This is something that could be improved upon later to enhance the experience.
No description provided.