Skip to content

GithubPublisher does not respect detectUpdateChannel setting #8589

Closed as not planned
@rotu

Description

@rotu
  • Electron-Builder Version: 25.1.7
  • Node Version: 22.9.0
  • Electron Version: 32.1.2
  • Electron Type (current, beta, nightly): current

N/A

  • Target: nsis

I'm using electron-builder with detectUpdateChannel = true, generateUpdatesFilesForAllChannels = true, and publish.provider = "github", and it will not set the channel based on the version (e.g. 1.2.3-beta.4 in my package.json. All builds wind up creating a latest.yml file.

electron-builder does emit the channel-specific yaml if I set publish.channel explicitly.

It seems the logic to do this is typically in SomePublisherClass.checkAndResolveOptions1 but GitHubPublisher has no such function, instead doing all options logic in the constructor2.

Footnotes

  1. https://github.com/electron-userland/electron-builder/blob/8cc2b42a0386d07b90749b5ce52de221786c46a2/packages/app-builder-lib/src/publish/PublishManager.ts#L481-L516

  2. https://github.com/electron-userland/electron-builder/blob/8cc2b42a0386d07b90749b5ce52de221786c46a2/packages/electron-publish/src/gitHubPublisher.ts

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions