This repository was archived by the owner on Feb 6, 2024. It is now read-only.
feat(youtube): add toggle method #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
added a commit
that referenced
this pull request
Feb 14, 2019
|
Cool idea and thx for the PR @natemoo-re 👍 After merge I allowed my self to remove the I also added the new method to the DeckDeckGo docs (not yet published, https://github.com/deckgo/deckdeckgo-docs/commit/84af7e780833a0e7e64cb4ed349752154072e5db) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
@Method() toggleto the<deckgo-slide-youtube>component, which alternates betweenplayandpausestates.TODO: post a message from the YouTube iFrame when the video is played/paused, so that
<deckgo-slide-youtube>keeps an internal@State() isPlayingin sync with the video. Currently this implementation only works ifplay,pause, ortoggleare called programmatically.