Skip to content

Run pre-commit in GitHub Actions #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Run pre-commit in GitHub Actions #1052

merged 5 commits into from
Apr 12, 2024

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 4, 2024

Description

Currently, local development checking (pre-commit) and CI checking are inconsistent. Changing the command run in GitHub Actions to pre-commit for consistent development experience.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

GitHub Actions should check the same thing as pre-commit (local development)

Steps to Test This Pull Request

Wait for CI to run

Additional context

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (120d514) to head (44c6f09).
Report is 269 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   97.33%   97.50%   +0.16%     
==========================================
  Files          42       55      +13     
  Lines        2104     2446     +342     
==========================================
+ Hits         2048     2385     +337     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.50% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

(I'll rebase on this, I started to work on a #724 revival/continuation)

@Lee-W Lee-W force-pushed the run-pre-commit-on-ci branch from 35b9f77 to a7c0d1f Compare April 11, 2024 15:15
@Lee-W Lee-W force-pushed the run-pre-commit-on-ci branch from a7c0d1f to 44c6f09 Compare April 12, 2024 00:15
@Lee-W Lee-W merged commit 18b471a into master Apr 12, 2024
18 checks passed
@Lee-W Lee-W deleted the run-pre-commit-on-ci branch April 12, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants